Skip to content

Keep starter links under Astro base - #112

Closed
sansynx wants to merge 1 commit into
cloudflare:mainfrom
sansynx:fix/subpath-base-urls
Closed

sansynx wants to merge 1 commit into
cloudflare:mainfrom
sansynx:fix/subpath-base-urls

Conversation

@sansynx

@sansynx sansynx commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

This fixes the sub-path links and assets described in #105:

  • prefix the framework favicon and Shiki stylesheet with Astro's configured base
  • apply the same helper to starter sidebar links, breadcrumbs, pagination, header navigation, 404, and deprecated-version links
  • add a regression contract covering the framework component and the canonical starter files

The root index route noted in the issue is handled separately in #111.

Verification

  • node --import tsx --test test/subpath-template-contract.test.ts test/url.test.ts
  • pnpm --filter nimbus-docs typecheck
  • pnpm --filter nimbus-docs build
  • pnpm --filter nimbus-starter-source typecheck
  • pnpm --filter nimbus-starter-source build
  • generated, scaffolded, installed, typechecked, and built a starter from the packed framework package
  • built and browsed the starter at /spike; favicon, Shiki CSS, sidebar, breadcrumbs, header, and navigation all resolved under that path

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MohamedH1998

Copy link
Copy Markdown
Collaborator

Appreciate the PR, but this has been also resolved on main as part of the broader server-side rendering and API-reference work in #114.

@sansynx

sansynx commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Got it, thanks for the heads up. I'll leave this one closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants